Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: enable cpuset support for cgroups.v2 #12274

Merged
merged 2 commits into from
Mar 24, 2022
Merged

client: enable cpuset support for cgroups.v2 #12274

merged 2 commits into from
Mar 24, 2022

Commits on Mar 23, 2022

  1. client: enable support for cgroups v2

    This PR introduces support for using Nomad on systems with cgroups v2 [1]
    enabled as the cgroups controller mounted on /sys/fs/cgroups. Newer Linux
    distros like Ubuntu 21.10 are shipping with cgroups v2 only, causing problems
    for Nomad users.
    
    Nomad mostly "just works" with cgroups v2 due to the indirection via libcontainer,
    but not so for managing cpuset cgroups. Before, Nomad has been making use of
    a feature in v1 where a PID could be a member of more than one cgroup. In v2
    this is no longer possible, and so the logic around computing cpuset values
    must be modified. When Nomad detects v2, it manages cpuset values in-process,
    rather than making use of cgroup heirarchy inheritence via shared/reserved
    parents.
    
    Nomad will only activate the v2 logic when it detects cgroups2 is mounted at
    /sys/fs/cgroups. This means on systems running in hybrid mode with cgroups2
    mounted at /sys/fs/cgroups/unified (as is typical) Nomad will continue to
    use the v1 logic, and should operate as before. Systems that do not support
    cgroups v2 are also not affected.
    
    When v2 is activated, Nomad will create a parent called nomad.slice (unless
    otherwise configured in Client conifg), and create cgroups for tasks using
    naming convention <allocID>-<task>.scope. These follow the naming convention
    set by systemd and also used by Docker when cgroups v2 is detected.
    
    Client nodes now export a new fingerprint attribute, unique.cgroups.version
    which will be set to 'v1' or 'v2' to indicate the cgroups regime in use by
    Nomad.
    
    The new cpuset management strategy fixes #11705, where docker tasks that
    spawned processes on startup would "leak". In cgroups v2, the PIDs are
    started in the cgroup they will always live in, and thus the cause of
    the leak is eliminated.
    
    [1] https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html
    
    Closes #11289
    Fixes #11705 #11773 #11933
    shoenig committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    5da1a31 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Configuration menu
    Copy the full SHA
    c27af79 View commit details
    Browse the repository at this point in the history