ci: limit gotestsum to circle ci #12321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 2 of breaking up #12255 This PR makes it so gotestsum is invoked only in CircleCI. Also the HCLogger(t) is plumbed more correctly in TestServer and TestAgent so that they respect NOMAD_TEST_LOG_LEVEL. The reason for these is we'll want to disable logging in GHA, where spamming the disk with logs really drags performance.
tgross
approved these changes
Mar 18, 2022
lgfa29
pushed a commit
that referenced
this pull request
Apr 28, 2022
ci: limit gotestsum to circle ci
lgfa29
pushed a commit
that referenced
this pull request
Apr 29, 2022
ci: limit gotestsum to circle ci
This was referenced Apr 29, 2022
lgfa29
added a commit
that referenced
this pull request
Apr 29, 2022
* Merge pull request #11889 from hashicorp/build-update-circle build: upgrade circleci configuration * Merge pull request #12299 from hashicorp/ci-parallel ci: trade test parallelization for unconstrained gomaxprocs * Merge pull request #12321 from hashicorp/ci-less-logging ci: limit gotestsum to circle ci * CI: build binaries for UI branches (#12594) Build binaries for every code change, not just backend code changes. This means that we'll have up-to-date compiled assets for every commit available in CircleCI artifacts. * Merge pull request #12736 from hashicorp/build-update-go-1.17.9 build: update golang to 1.17.9 * cgutil test: reserve only a single CPU for AddAlloc test Reserving the entire machine's worth of CPUs for the `AddAlloc` test triggers a condition where the empty shared CPUs defaults to the parent CPU set on some system configurations. This was done in `main` as part of cgroups v2 work, but we need to backport this to earlier branches in order to use the same machines across branches. Co-authored-by: Seth Hoenig <seth.a.hoenig@gmail.com> Co-authored-by: Tim Gross <tgross@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Apr 29, 2022
* Merge pull request #11889 from hashicorp/build-update-circle build: upgrade circleci configuration * Merge pull request #12299 from hashicorp/ci-parallel ci: trade test parallelization for unconstrained gomaxprocs * Merge pull request #12321 from hashicorp/ci-less-logging ci: limit gotestsum to circle ci * CI: build binaries for UI branches (#12594) Build binaries for every code change, not just backend code changes. This means that we'll have up-to-date compiled assets for every commit available in CircleCI artifacts. * cgutil test: reserve only a single CPU for AddAlloc test Reserving the entire machine's worth of CPUs for the `AddAlloc` test triggers a condition where the empty shared CPUs defaults to the parent CPU set on some system configurations. This was done in `main` as part of cgroups v2 work, but we need to backport this to earlier branches in order to use the same machines across branches. Co-authored-by: Seth Hoenig <seth.a.hoenig@gmail.com> Co-authored-by: Tim Gross <tgross@hashicorp.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of breaking up #12255
This PR makes it so
gotestsumis invoked only in CircleCI. Also theHCLogger(t)is plumbed more correctly inTestServerandTestAgentsothat they respect
NOMAD_TEST_LOG_LEVEL.The reason for these is we'll want to disable logging in GHA,
where spamming the disk with logs drags performance.
Also upgrade
gotestsumwhile we're here.