Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport CI changes to 1.2.x #12823

Merged
merged 6 commits into from
Apr 29, 2022
Merged

Backport CI changes to 1.2.x #12823

merged 6 commits into from
Apr 29, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Apr 29, 2022

Backport the following PRs to release/1.2.x to keep our CI test suite in sync with main:

#11889
#12299
#12321
#12594
#12736

The main conflicts happened when adding the ci.Parallel(t) as it touched pretty much all test files. I kept things as they were in release/1.2.x and deleted tests that only exist in main.

shoenig and others added 6 commits April 28, 2022 18:48
build: upgrade circleci configuration
ci: trade test parallelization for unconstrained gomaxprocs
Build binaries for every code change, not just backend code
changes. This means that we'll have up-to-date compiled assets for
every commit available in CircleCI artifacts.
Reserving the entire machine's worth of CPUs for the `AddAlloc` test
triggers a condition where the empty shared CPUs defaults to the
parent CPU set on some system configurations. This was done in `main`
as part of cgroups v2 work, but we need to backport this to earlier
branches in order to use the same machines across branches.
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the GH diff viewer just gives up after a while

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgfa29 lgfa29 merged commit d27c703 into release/1.2.x Apr 29, 2022
@lgfa29 lgfa29 deleted the release/1.2.x-ci-sync branch April 29, 2022 15:39
@shoenig shoenig mentioned this pull request Jun 2, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants