-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport CI changes to 1.2.x #12823
Backport CI changes to 1.2.x #12823
Conversation
build: upgrade circleci configuration
ci: trade test parallelization for unconstrained gomaxprocs
ci: limit gotestsum to circle ci
Build binaries for every code change, not just backend code changes. This means that we'll have up-to-date compiled assets for every commit available in CircleCI artifacts.
build: update golang to 1.17.9
Reserving the entire machine's worth of CPUs for the `AddAlloc` test triggers a condition where the empty shared CPUs defaults to the parent CPU set on some system configurations. This was done in `main` as part of cgroups v2 work, but we need to backport this to earlier branches in order to use the same machines across branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the GH diff viewer just gives up after a while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Backport the following PRs to
release/1.2.x
to keep our CI test suite in sync withmain
:#11889
#12299
#12321
#12594
#12736
The main conflicts happened when adding the
ci.Parallel(t)
as it touched pretty much all test files. I kept things as they were inrelease/1.2.x
and deleted tests that only exist inmain
.