Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test the buffered pipe used by nsd #12563

Merged
merged 1 commit into from
Apr 14, 2022
Merged

test: test the buffered pipe used by nsd #12563

merged 1 commit into from
Apr 14, 2022

Conversation

schmichael
Copy link
Member

@schmichael schmichael commented Apr 13, 2022

Fixes #12483

Nomad Service Discovery uses an in-memory buffered pipe implementation
to connect consul-template to the Nomad API.

This adds a basic test for that helper functionality.

Nomad Service Discovery uses an in-memory buffered pipe implementation
to connect consul-template to the Nomad API.

This adds a basic test for that helper functionality.
@schmichael schmichael requested a review from jrasell April 13, 2022 23:06
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@schmichael schmichael merged commit 29af989 into main Apr 14, 2022
@schmichael schmichael deleted the test-bufconn branch April 14, 2022 15:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test bufconndialer package
2 participants