Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CSI: add missing fields to HTTP API response into release/1.1.x #12668

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12178 to be assessed for backporting due to the inclusion of the label backport/1.1.x.

The below text is copied from the body of the original PR.


The HTTP endpoint for CSI manually serializes the internal struct to
the API struct for purposes of redaction (see also #10470). Add fields
that were missing from this serialization so they don't show up as
always empty in the API response.

Found these while testing #12167
That PR won't get backported but we'll want this one to be.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/csi-structs-to-api-fix/greatly-singular-catfish branch from 9814d48 to 715a3d3 Compare April 19, 2022 18:27
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 9ad74d7 into release/1.1.x Apr 19, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/csi-structs-to-api-fix/greatly-singular-catfish branch April 19, 2022 18:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants