-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace structs.CSIPlugin -> api.CSIPlugin conversion #10470
Labels
Comments
cc @DerekStrickland as a heads up |
tgross
added a commit
that referenced
this issue
Feb 24, 2022
tgross
added a commit
that referenced
this issue
Mar 3, 2022
The HTTP endpoint for CSI manually serializes the internal struct to the API struct for purposes of redaction (see also #10470). Add fields that were missing from this serialization so they don't show up as always empty in the API response.
tgross
added a commit
that referenced
this issue
Mar 3, 2022
The HTTP endpoint for CSI manually serializes the internal struct to the API struct for purposes of redaction (see also #10470). Add fields that were missing from this serialization so they don't show up as always empty in the API response.
tgross
added a commit
that referenced
this issue
Mar 3, 2022
The HTTP endpoint for CSI manually serializes the internal struct to the API struct for purposes of redaction (see also #10470). Add fields that were missing from this serialization so they don't show up as always empty in the API response.
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In #8590 we introduced a manual conversion between
structs.CSIPlugin
andapi.CSIPlugin
. This proved to be fiddly and error-prone. #10202 introduced some encoding improvements that make it possible to remove most of this code so that we can implement a few hooks for fields we want to redact and that's it.The text was updated successfully, but these errors were encountered: