Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: volume and plugin allocations in the API #8590

Merged
merged 10 commits into from
Aug 11, 2020
Merged

Conversation

langmartin
Copy link
Contributor

API representations of individual plugins and volumes include correct allocation data

Fixes #8362 and similar issue for plugins

@langmartin langmartin changed the title B csi volume allocs CSI: volume and plugin allocations in the API Aug 5, 2020
@langmartin langmartin added this to the 0.12.2 milestone Aug 6, 2020
@langmartin langmartin marked this pull request as ready for review August 7, 2020 17:39
@langmartin langmartin requested a review from tgross August 7, 2020 17:39
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left one big question but it's entirely possible I'm barking up the wrong tree on that.

command/agent/csi_endpoint.go Show resolved Hide resolved
command/agent/csi_endpoint.go Show resolved Hide resolved
nomad/state/testing.go Show resolved Hide resolved
@langmartin langmartin merged commit 8a095fc into master Aug 11, 2020
@langmartin langmartin deleted the b-csi-volume-allocs branch August 11, 2020 16:24
tgross added a commit that referenced this pull request Apr 15, 2022
The CSI HTTP API has to transform the CSI volume to redact secrets,
remove the claims fields, and to consolidate the allocation stubs into
a single slice of alloc stubs. This was done manually in #8590 but
this is a large amount of code and has proven both very bug prone
(see #8659, #8666, #8699, #8735, and #12150) and requires updating
lots of code every time we add a field to volumes or plugins.

In #10202 we introduce encoding improvements for the `Node` struct
that allow a more minimal transformation. Apply this same approach to
serializing `structs.CSIVolume` to API responses.

Also, the original reasoning behind #8590 for plugins no longer holds
because the counts are now denormalized within the state store, so we
can simply remove this transformation entirely.
tgross added a commit that referenced this pull request Apr 15, 2022
The CSI HTTP API has to transform the CSI volume to redact secrets,
remove the claims fields, and to consolidate the allocation stubs into
a single slice of alloc stubs. This was done manually in #8590 but
this is a large amount of code and has proven both very bug prone
(see #8659, #8666, #8699, #8735, and #12150) and requires updating
lots of code every time we add a field to volumes or plugins.

In #10202 we introduce encoding improvements for the `Node` struct
that allow a more minimal transformation. Apply this same approach to
serializing `structs.CSIVolume` to API responses.

Also, the original reasoning behind #8590 for plugins no longer holds
because the counts are now denormalized within the state store, so we
can simply remove this transformation entirely.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] CSI Volume Listing has invalid Allocation Count
2 participants