Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] fix gateway listener docs when registering a non-tcp protocol #13230

Merged
merged 7 commits into from
Jun 6, 2022
Merged

[doc] fix gateway listener docs when registering a non-tcp protocol #13230

merged 7 commits into from
Jun 6, 2022

Conversation

Dgotlieb
Copy link
Contributor

@Dgotlieb Dgotlieb commented Jun 6, 2022

Due to an open issue, services with a protocol different than tcp need to be preconfigured to Consul service-default

tgross
tgross approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Dgotlieb. I'll merge this once our preview builds.

@tgross
Copy link
Member

tgross commented Jun 6, 2022

Preview link: https://nomad-qzldsvo2a-hashicorp.vercel.app/docs/job-specification/gateway#protocol

@tgross tgross added backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line labels Jun 6, 2022
@tgross tgross merged commit 99b9408 into hashicorp:main Jun 6, 2022
This was referenced Jun 6, 2022
Merged
Closed
Merged
Merged
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dgotlieb @tgross @lgfa29