Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] fix gateway listener docs when registering a non-tcp protocol #13230

Merged
merged 7 commits into from
Jun 6, 2022
Merged

[doc] fix gateway listener docs when registering a non-tcp protocol #13230

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5bfce06
Add grpc and http2 listeners to gateway docs
Dgotlieb Mar 24, 2022
2f07421
Update gateway.mdx
Dgotlieb Mar 24, 2022
994bf52
Merge pull request #1 from Dgotlieb/add-grpc-and-http2-to-gateway-lis…
Dgotlieb Mar 24, 2022
952d81e
docs: fix markup
lgfa29 Mar 24, 2022
034c2eb
fix docs for gateway listener
Dgotlieb Jun 6, 2022
283c789
Merge branch 'hashicorp:main' into main
Dgotlieb Jun 6, 2022
c00417e
Update gateway.mdx
Dgotlieb Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/content/docs/job-specification/gateway.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ envoy_gateway_bind_addresses "<service>" {
- `protocol` `(string: "tcp")` - The protocol associated with the listener. One
of `tcp`, `http`, `http2`, or `grpc`.

~> **Note:** If using `http`, preconfiguring a [service-default] in Consul to
~> **Note:** If using any protocol other than `tcp` (for example: `http` or `grpc`), preconfiguring a [service-default] in Consul to
set the [Protocol](https://www.consul.io/docs/agent/config-entries/service-defaults#protocol)
of the service to `http` is recommended.
of the service to the desired protocol is mandatory due to an [open issue](https://github.com/hashicorp/nomad/issues/8647).

- `service` <code>(array<[service]>: required)</code> - One or more services to be
exposed via this listener. For `tcp` listeners, only a single service is allowed.
Expand Down