Replaced other instances of IvyCodeMirror throughout the app #13528
Conversation
Ember Asset Size actionAs of 858b08f Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
| mode="javascript" | ||
| {{code-mirror | ||
| screenReaderLabel="Job definition" | ||
| content=(or this.job._newDefinition this.jobSpec) |
There was a problem hiding this comment.
blocking question: JobEditor doesn't have a jobSpec property and neither of these properties are reactive, however, we call set on _newDefintion which might do the trick.
Do we know where this.jobSpec is coming from? Searching the codebase, this is the only use of jobSpec?
There was a problem hiding this comment.
Looks like it used to be something that could be passed in and just never got cleaned up (it's present in the IvyCodemirror code, too)
I'll remove it here
There was a problem hiding this comment.
This could introduce a potential breaking change and thankfully it'll be shipped in a major release. But, I'd love to chat with @lgfa29 re: UI release process.
@lgfa29 - we have some serious re-designs for the Job Detail Overview page (this PR is unrelated to that) coming down the pipe. But, this PR is a good example of potential breaking API changes in our UI code. Should we start coordinating with the release process for these types of things?
There was a problem hiding this comment.
I don't think we need any special coordination. Since this is all set to go out with 1.4.0 all we need is for the changes to be in main before the release.
One thing we can do is to update bindata_assetfs.go in main so that anyone running make dev will see the latest UI changes before the release. This can help get more eyes and test major changes before the beta.
| return cm; | ||
| export function getCodeMirrorInstance() { | ||
| return function () { | ||
| return document.querySelector('.CodeMirror').CodeMirror; |
There was a problem hiding this comment.
suggestion: We can deprecate this helper entirely now this its just selecting a DOM element without tapping into the container registry or throwing an error.
Its used in 3 files. And we should be able to write:
const expected = document.querySelector('.CodeMirror').CodeMirror.value;
const actual = JSON.stringify(result, null, 2);
assert.equals(expected, actual);
* Toying with insert and update helpers before translation func * Working prototype that lets you switch between json and tabular * No longer add the bonus items row in json mode * Trimmed the ivy from the codemirror (#13503) * Trimmed the ivy from the codemirror * editedJSONItems removal * De-debugger * Replaced other instances of IvyCodeMirror throughout the app (#13528) * Replaced other instances of IvyCodeMirror throughout the app * PR requests for codemirror modifier * Screen reader setting as param * Trying a simpler codemirror test helper * Lint removal * Screen Reader Label added for a11y * JSONViewer cleanup * JSON editor added to /new and all variables stringified before save or translate * Give users a foothold when editing an empty item in JSON mode * Copy the empty KV * No duplicate keys in KV * Better handling of cursor snapping in json edit field * Catch formatting errors on the fly * Basic tests for JSON to Table and Table to JSON in form
* Toying with insert and update helpers before translation func * Working prototype that lets you switch between json and tabular * No longer add the bonus items row in json mode * Trimmed the ivy from the codemirror (#13503) * Trimmed the ivy from the codemirror * editedJSONItems removal * De-debugger * Replaced other instances of IvyCodeMirror throughout the app (#13528) * Replaced other instances of IvyCodeMirror throughout the app * PR requests for codemirror modifier * Screen reader setting as param * Trying a simpler codemirror test helper * Lint removal * Screen Reader Label added for a11y * JSONViewer cleanup * JSON editor added to /new and all variables stringified before save or translate * Give users a foothold when editing an empty item in JSON mode * Copy the empty KV * No duplicate keys in KV * Better handling of cursor snapping in json edit field * Catch formatting errors on the fly * Basic tests for JSON to Table and Table to JSON in form
* Toying with insert and update helpers before translation func * Working prototype that lets you switch between json and tabular * No longer add the bonus items row in json mode * Trimmed the ivy from the codemirror (#13503) * Trimmed the ivy from the codemirror * editedJSONItems removal * De-debugger * Replaced other instances of IvyCodeMirror throughout the app (#13528) * Replaced other instances of IvyCodeMirror throughout the app * PR requests for codemirror modifier * Screen reader setting as param * Trying a simpler codemirror test helper * Lint removal * Screen Reader Label added for a11y * JSONViewer cleanup * JSON editor added to /new and all variables stringified before save or translate * Give users a foothold when editing an empty item in JSON mode * Copy the empty KV * No duplicate keys in KV * Better handling of cursor snapping in json edit field * Catch formatting errors on the fly * Basic tests for JSON to Table and Table to JSON in form
* Toying with insert and update helpers before translation func * Working prototype that lets you switch between json and tabular * No longer add the bonus items row in json mode * Trimmed the ivy from the codemirror (#13503) * Trimmed the ivy from the codemirror * editedJSONItems removal * De-debugger * Replaced other instances of IvyCodeMirror throughout the app (#13528) * Replaced other instances of IvyCodeMirror throughout the app * PR requests for codemirror modifier * Screen reader setting as param * Trying a simpler codemirror test helper * Lint removal * Screen Reader Label added for a11y * JSONViewer cleanup * JSON editor added to /new and all variables stringified before save or translate * Give users a foothold when editing an empty item in JSON mode * Copy the empty KV * No duplicate keys in KV * Better handling of cursor snapping in json edit field * Catch formatting errors on the fly * Basic tests for JSON to Table and Table to JSON in form
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Twig of #13441 — replaces all old instances of
<IvyCodemirror>with the new modifier, and makes some small edit to the codemirror modifier itself.