Nomad Services: job routes, model, and serializer updates #14226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 25ccc3b Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
ChaiWithJai
reviewed
Aug 23, 2022
ChaiWithJai
approved these changes
Aug 24, 2022
philrenaud
changed the title
ChaiWithJai
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Added to subnav and basic table implemented * Existing services become service fragments, and services tab aggregated beneath job route * Index page within jobs/job/services * Watchable services * Lintfixes * Links to clients and individual services set up * Child service route * Keyboard shortcuts on service page * Model that shows consul services as well, plus level and provider cols * lintfix * Level as query param * Watch job for service name changes too * Lintfix * Testfixes * Placeholder mirage route
philrenaud
added a commit
that referenced
this pull request
Aug 31, 2022
* Added to subnav and basic table implemented * Existing services become service fragments, and services tab aggregated beneath job route * Index page within jobs/job/services * Watchable services * Lintfixes * Links to clients and individual services set up * Child service route * Keyboard shortcuts on service page * Model that shows consul services as well, plus level and provider cols * lintfix * Level as query param * Watch job for service name changes too * Lintfix * Testfixes * Placeholder mirage route
philrenaud
added a commit
that referenced
this pull request
Sep 7, 2022
* Added to subnav and basic table implemented * Existing services become service fragments, and services tab aggregated beneath job route * Index page within jobs/job/services * Watchable services * Lintfixes * Links to clients and individual services set up * Child service route * Keyboard shortcuts on service page * Model that shows consul services as well, plus level and provider cols * lintfix * Level as query param * Watch job for service name changes too * Lintfix * Testfixes * Placeholder mirage route
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a jobs/:jobid/services route and child routes
TODO:
Side-effects:
servicemodel renamed toservice-fragment; still in use on allocations pagereplaceflag to watchRelationships method, that when true, will unload all instances of a type from the store.unloadAllwhen the replace flag is set, we only see those services that were returned in the latest refresh.Resolves #14202
Resolves #14213