☂️ Service Discovery UI

[philrenaud]

A note on Abilities/ACLs:

• Services do not have their own ACL requirements; they depend on read-job alone for viewing, and submit-job in the case of service de-registration, which the UI will not handle.

Services Tab (ui/services)

NOTE: On hold / de-prioritized for inefficient number of calls that would be required.

General Service model and fixture updates

• 8 Model, Serializer and Adapter updates (replace existing fragment; make watchable)
• 3 Mirage fixtures
• 5 E2E tests using Mirage fixtures

Job-contextual Services Tab (ui/jobs/:JOBID/services and ui/jobs/:JOBID/services/:SERVICEID)

• 3 Scaffold a jobs/job/services route
  • 1 Aggregate allocations by Alloc ID
• 1 Scaffold new child route
• 0 Add new LinkTo to Job subnav
• 1 If job spec has any consul services, warn them on the jobs/services page that we don't show those there, and link to docs. nvm! Can show Consul services, too!

Allocation-contextual Services Table (ui/allocations/:ALLOCID)

• 3 Health Checks (v1/allocation/:ALLOCID/checks)
• 1 Aggregate check status for a given service into a health check bar
• STRETCH 3 Merge existing services that come back with the allocation, and may include Consul services, with Nomad ones that come back from /checks)
• handle visualizing health status checks for duplicate services
• 2 Show Task-level services on the alloc page

Allocation-contextual Service-specific Flyout (ui/allocations/:ALLOCID?service=:SERVICEID)

• 1 Table setup
• 2 Format error output for failing states
• 1 Query Parameters for reload etc.
• [ui] Service Discovery Health Checks: show Sparklines indicating previous health check results #14482

[ChaiWithJai]

E2E tests using Mirage fixtures

You mean acceptance tests? Or E2E in Playwright?

[philrenaud]

You mean acceptance tests? Or E2E in Playwright?

Acceptance tests

[ChaiWithJai]

Health Checks (v1/allocation/:ALLOCID/checks)

It appears that this block of work must occur before "Aggregate check status for a given service into a health check bar" can happen and before any work in "Allocation-contextual Service-specific Flyout" can happen.

[ChaiWithJai]

STRETCH 3 Merge existing services that come back with the allocation, and may include Consul services, with Nomad ones that come back from /checks)

Should we mark this as not possible?

[philrenaud]

STRETCH 3 Merge existing services that come back with the allocation, and may include Consul services, with Nomad ones that come back from /checks)

Should we mark this as not possible?

I think this is actually the default way that things will work; we use the current list to show both consul and nomad services, and we hydrate the nomad ones with health check statuses.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.