Job Services: fixtures and acceptance tests #14319

philrenaud · 2022-08-25T03:06:11Z

Adds Mirage fixtures and basic acceptance tests for the Job Services tab

…ed beneath job route

github-actions · 2022-08-25T03:12:42Z

Ember Asset Size action

As of 48d5c42

Files that got Bigger 🚨:

File	raw	gzip
nomad-ui.js	+1.13 kB	+188 B

Files that stayed the same size 🤷‍:

File	raw	gzip
vendor.js	0 B	0 B
nomad-ui.css	0 B	0 B
vendor.css	0 B	0 B

github-actions · 2022-08-25T05:04:54Z

Ember Test Audit comparison

	14202-scaffold-new-parent-route	`6fd4c60`	change
passes	1416	186	-1230
failures	3	19	+16
flaky	0	0	0
duration	000ms	000ms	-000ms

ChaiWithJai

LGTM

ChaiWithJai · 2022-08-25T17:44:12Z

ui/mirage/factories/service.js

+
+  afterCreate(service, server) {
+    if (!service.namespace) {
+      const namespace = pickOne(server.db.jobs)?.namespace || 'default';


This is randomly going to pick a job and assign the namespace of that job to this Service instead of taking the related job's namespace. Which could cause weird test related bugs down the line.

ChaiWithJai · 2022-08-25T17:46:23Z

ui/mirage/factories/service.js

+    if (server.db.jobs.findBy({ id: 'service-haver' })) {
+      if (!service.jobId) {
+        service.update({
+          jobId: 'service-haver',
+        });
+      }


Should this logic be tied to the namespace assignment? Will this logic mix well with allScenarios in mirage?

In testing re: allScenarios, so far so good.

I don't think it should be tied to the namespace assignment; it's in the same afterCreate block but otherwise separated.

philrenaud · 2022-08-25T17:20:38Z

ui/app/components/job-service-row.js

@@ -10,7 +10,7 @@ export default class JobServiceRowComponent extends Component {
    if (service.provider === 'nomad') {
      this.router.transitionTo('jobs.job.services.service', service.name, {
        queryParams: { level: service.level },
-				instances: service.instances,
+        instances: service.instances,


Prettier side-effect; please ignore

philrenaud · 2022-08-25T17:20:44Z

ui/app/routes/jobs/job/services/service.js

@@ -1,10 +1,12 @@
 import Route from '@ember/routing/route';

 export default class JobsJobServicesServiceRoute extends Route {
-  model({name = "", level = ""}) {
+  model({ name = '', level = '' }) {


Prettier side-effect; please ignore

* Added to subnav and basic table implemented * Existing services become service fragments, and services tab aggregated beneath job route * Index page within jobs/job/services * Watchable services * Lintfixes * Links to clients and individual services set up * Child service route * Keyboard shortcuts on service page * Model that shows consul services as well, plus level and provider cols * lintfix * Level as query param * Watch job for service name changes too * Group level service fixtures established * Progress at task level and job-linked services * Task and group services on update * Fixture side-effect cleanup * Basic acceptance tests for job services * Testmodel cleanup * Disabled mirage logging * New cluster type specifically for services * Without explicit job-model binding * Trying to isolate a tostring error * Account for new tab in keyboardnav * More test isolation attempts * Remove skipped tests and link task to parent group by id ui: add service health viz to table (#14369) * ui: add service-status-bar * test: service-status-bar * refact: update component api for new data struct * ui: format service health struct * ui: add service health viz to table * temp: add placeholder to remind conditional watcher * test: write tests for transformation algorithm * refact: update transformation algo * ui: conditionally long poll checks endpoint * refact: add conditional logic for nomad provider refact: update service-fragment model to include owner info ui: differentiate between task and group-level in derived state comp test: add test to document behavior refact: update tests for api change refact: update integration test for API change chore: remove unsused vars chore: elvis operator to protect mirage refact: create refId instead of internalModel refact: update algo refact: update conditional template logic refact: update test for api change: chore: cant use if and not in hbs conditional

github-actions · 2022-12-28T02:14:59Z

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

philrenaud added 13 commits August 22, 2022 13:05

Added to subnav and basic table implemented

4a3d70f

Existing services become service fragments, and services tab aggregat…

a0ceef9

…ed beneath job route

Index page within jobs/job/services

162c328

Watchable services

696e9a0

Lintfixes

1298a3a

Links to clients and individual services set up

2cf8f94

Child service route

92c24f7

Keyboard shortcuts on service page

caa0fd6

Model that shows consul services as well, plus level and provider cols

fba5459

lintfix

1bc0c35

Level as query param

3abd189

Watch job for service name changes too

a29c0a9

Group level service fixtures established

18fa22c

Progress at task level and job-linked services

5dc20de

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 04:29 View deployment

Task and group services on update

18bbca0

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 15:14 View deployment

Fixture side-effect cleanup

6fd4c60

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 15:21 View deployment

Basic acceptance tests for job services

4a3938d

philrenaud changed the title ~~Group level service fixtures established~~ Job Services: fixtures and acceptance tests Aug 25, 2022

philrenaud requested a review from ChaiWithJai August 25, 2022 17:19

philrenaud marked this pull request as ready for review August 25, 2022 17:20

Testmodel cleanup

62e8b99

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 17:24 View deployment

ChaiWithJai approved these changes Aug 25, 2022

View reviewed changes

Disabled mirage logging

dff82f3

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 17:58 View deployment

New cluster type specifically for services

4426708

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 18:22 View deployment

philrenaud commented Aug 25, 2022

View reviewed changes

Without explicit job-model binding

a1d0211

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 18:42 View deployment

Trying to isolate a tostring error

f2624b8

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 19:08 View deployment

Account for new tab in keyboardnav

04ca28b

vercel bot deployed to Preview – nomad-storybook-and-ui August 25, 2022 19:21 View deployment

Base automatically changed from 14202-scaffold-new-parent-route to f-ui/service-discovery August 26, 2022 03:22

Updated to latest base

3b63047

vercel bot deployed to Preview – nomad-storybook-and-ui August 26, 2022 13:26 View deployment

More test isolation attempts

cac5528

vercel bot deployed to Preview – nomad-storybook-and-ui August 26, 2022 14:46 View deployment

Remove skipped tests and link task to parent group by id

48d5c42

vercel bot deployed to Preview – nomad-storybook-and-ui August 29, 2022 17:43 View deployment

philrenaud merged commit 9f89bab into f-ui/service-discovery Aug 29, 2022

philrenaud deleted the 14202-services-fixtures branch August 29, 2022 18:04

philrenaud mentioned this pull request Aug 29, 2022

☂️ Service Discovery UI #14193

Closed

17 tasks

github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Job Services: fixtures and acceptance tests #14319

Job Services: fixtures and acceptance tests #14319

philrenaud commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading

ChaiWithJai left a comment

ChaiWithJai Aug 25, 2022

ChaiWithJai Aug 25, 2022

philrenaud Aug 29, 2022

philrenaud Aug 25, 2022

philrenaud Aug 25, 2022

github-actions bot commented Dec 28, 2022

Job Services: fixtures and acceptance tests #14319

Job Services: fixtures and acceptance tests #14319

Conversation

philrenaud commented Aug 25, 2022 • edited Loading

github-actions bot commented Aug 25, 2022 • edited Loading

Ember Asset Size action

github-actions bot commented Aug 25, 2022 • edited Loading

Ember Test Audit comparison

ChaiWithJai left a comment

Choose a reason for hiding this comment

ChaiWithJai Aug 25, 2022

Choose a reason for hiding this comment

ChaiWithJai Aug 25, 2022

Choose a reason for hiding this comment

philrenaud Aug 29, 2022

Choose a reason for hiding this comment

philrenaud Aug 25, 2022

Choose a reason for hiding this comment

philrenaud Aug 25, 2022

Choose a reason for hiding this comment

github-actions bot commented Dec 28, 2022

philrenaud commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading