ui: add service health viz to table #14369
Conversation
Ember Asset Size actionAs of 30b0dfe Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
| @@ -13,6 +13,7 @@ export default class AllocationRoute extends Route.extend(WithWatchers) { | |||
| startWatchers(controller, model) { | |||
| if (model) { | |||
| controller.set('watcher', this.watch.perform(model)); | |||
| // TODO: Add conditional logic | |||
There was a problem hiding this comment.
@philrenaud on idea around conditionally polling services would be checking if model.get('job.service') which may be the more technically sound option because we specify services on the job specification -- not at the allocation level. And in our model hook, we make an async request to get the job already.
There was a problem hiding this comment.
model.get('job.services') will, I think, make a request to the API at /jobs/:jobid/services, which is perhaps not what we want.
If we want to look at those services defined in the job spec, that's exactly what the @union('taskServices', 'groupServices') services; references in allocation/index are doing. Those service definitions read from the responded job file, and don't make further requests. I'd consider porting those to the alloc controller or similar (anyplace higher level than the alloc index) and using that.
There was a problem hiding this comment.
OK, I ported over the union logic you have. Do you have any idea how I can test this? We disable watchers in our test suite.
So for this to be correct we need to test:
- When both tasks and task groups have services
- When only tasks have them
- When only groups have them
- When neither have them
I can only test 1 and 4 right now. @philrenaud can you assist, please?
Ember Test Audit comparison
|
| <td data-test-service-health> | ||
| {{#if (not row.model.connect)}} | ||
| <div class="inline-chart"> | ||
| <ServiceStatusBar @services={{this.serviceHealthStatuses}} @name={{row.model.name}} /> |
There was a problem hiding this comment.
Drop an @isNarrow={{true}} on this to more closely match designs
There was a problem hiding this comment.
Good catch! I should've read the component API better next time.
| const doesAllocHaveServices = | ||
| !!model.taskGroup.services || | ||
| !!model.states.mapBy('task').map((t) => t && t.get('services')); |
There was a problem hiding this comment.
Considering filtering these by provider === "nomad". We won't need to make health checks if we only have consul services and could save some network bandwidth for users.
| @@ -301,6 +304,13 @@ | |||
| {{upstream.destinationName}}:{{upstream.localBindPort}} | |||
| {{/each}} | |||
| </td> | |||
| <td data-test-service-health> | |||
| {{#if (not row.model.connect)}} | |||
There was a problem hiding this comment.
I don't think row.model.connect is correct here; there can be provider = "consul" services (service fragments) for which consult-connect is falsy. We don't want to show our chart for those, either.
There was a problem hiding this comment.
Instead, you probably want to do an eq test for provider: nomad
* Added to subnav and basic table implemented * Existing services become service fragments, and services tab aggregated beneath job route * Index page within jobs/job/services * Watchable services * Lintfixes * Links to clients and individual services set up * Child service route * Keyboard shortcuts on service page * Model that shows consul services as well, plus level and provider cols * lintfix * Level as query param * Watch job for service name changes too * Group level service fixtures established * Progress at task level and job-linked services * Task and group services on update * Fixture side-effect cleanup * Basic acceptance tests for job services * Testmodel cleanup * Disabled mirage logging * New cluster type specifically for services * Without explicit job-model binding * Trying to isolate a tostring error * Account for new tab in keyboardnav * More test isolation attempts * Remove skipped tests and link task to parent group by id ui: add service health viz to table (#14369) * ui: add service-status-bar * test: service-status-bar * refact: update component api for new data struct * ui: format service health struct * ui: add service health viz to table * temp: add placeholder to remind conditional watcher * test: write tests for transformation algorithm * refact: update transformation algo * ui: conditionally long poll checks endpoint * refact: add conditional logic for nomad provider refact: update service-fragment model to include owner info ui: differentiate between task and group-level in derived state comp test: add test to document behavior refact: update tests for api change refact: update integration test for API change chore: remove unsused vars chore: elvis operator to protect mirage refact: create refId instead of internalModel refact: update algo refact: update conditional template logic refact: update test for api change: chore: cant use if and not in hbs conditional
* Added to subnav and basic table implemented * Existing services become service fragments, and services tab aggregated beneath job route * Index page within jobs/job/services * Watchable services * Lintfixes * Links to clients and individual services set up * Child service route * Keyboard shortcuts on service page * Model that shows consul services as well, plus level and provider cols * lintfix * Level as query param * Watch job for service name changes too * Group level service fixtures established * Progress at task level and job-linked services * Task and group services on update * Fixture side-effect cleanup * Basic acceptance tests for job services * Testmodel cleanup * Disabled mirage logging * New cluster type specifically for services * Without explicit job-model binding * Trying to isolate a tostring error * Account for new tab in keyboardnav * More test isolation attempts * Remove skipped tests and link task to parent group by id ui: add service health viz to table (#14369) * ui: add service-status-bar * test: service-status-bar * refact: update component api for new data struct * ui: format service health struct * ui: add service health viz to table * temp: add placeholder to remind conditional watcher * test: write tests for transformation algorithm * refact: update transformation algo * ui: conditionally long poll checks endpoint * refact: add conditional logic for nomad provider refact: update service-fragment model to include owner info ui: differentiate between task and group-level in derived state comp test: add test to document behavior refact: update tests for api change refact: update integration test for API change chore: remove unsused vars chore: elvis operator to protect mirage refact: create refId instead of internalModel refact: update algo refact: update conditional template logic refact: update test for api change: chore: cant use if and not in hbs conditional
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR handles visualizing Service Health statuses in the
allocations.allocation.indexview within the Services table.This PR raises a concern about the response from
clients/allocations/:allocId/checksendpoint. Highlighting an issue where all services in the allocation are not returning a status and sometimes the API returnsnull.