checks: don't validate task/check compatibility for Connect services #14849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Nomad 1.4.0 we plumbed-through a task name to all checks in order to support native service discovery. For Connect tasks with a non-script/gRPC check, this triggers a validation error that setting the task name on a check isn't compatible with http/tpc checks. Normally this is correct behavior but for Connect tasks we need to include the `task` field. Bypass this validation for Connect services.
tgross
added
theme/consul/connect
jrasell
reviewed
Oct 10, 2022
|
@tgross per #14822 (comment) I'm gonna open another PR that removes the assertion altogether |
|
Closed in lieu of #14864 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14822
In Nomad 1.4.0 we plumbed-through a task name to all checks in order to support native service discovery. For Connect tasks with a non-script/gRPC check, this triggers a validation error that setting the task name on a check isn't compatible with http/tpc checks. Normally this is correct behavior but for Connect tasks we need to include the
taskfield. Bypass this validation for Connect services.Note to reviewers: see my comment in #14822 (comment). I've tested that this fixes the immediate problem but I'm not familiar enough with the original changes for service disco checks yet to feel super confident that this is the right approach.