Backport of [ui] Remove animation from task logs sidebar into release/1.4.x #15171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15146 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
The below text is copied from the body of the original PR.
Resolves #15113
Context: While our other sidebar portals (Evaluations, Services) are parent-contextual ("expand info on this already-existing child of my route"), Task logs are different: they fetch out-of-context information (logs for a task) from several different places (including a client index, or a job index).
Because of this:
<TaskSubRow>
components, conditional upon that row being selected (having "View Logs" clicked)This presents a problem: because the context can change (ie: job stops, client stops), the task log context also changes and gets "repainted" in the DOM. This caused the sidebar to "jitter" and fire its animation again as if it were a brand new element that needed to close and re-open again.
There is another way to solve this, involving moving the portal architecture for this to the application-level template (the html equivalent of global scope), but I've opted not to do this for maintainability reasons.
As such: hasta la vista to the sidebar animation. It now just pops open or closed upon clicking "View Logs"