Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make eval cancelation async with Eval.Ack #15294

Merged
merged 1 commit into from
Nov 17, 2022
Merged

make eval cancelation async with Eval.Ack #15294

merged 1 commit into from
Nov 17, 2022

Commits on Nov 17, 2022

  1. make eval cancelation async with Eval.Ack 

    In #14621 we added an eval canelation reaper goroutine with a channel that
allowed us to wake it up. But we forgot to actually send on this channel from
`Eval.Ack` and are still committing the cancelations synchronously. Fix this by
sending on the buffered channel to wake up the reaper instead.
    @tgross
    tgross committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    8f3106d View commit details
    Browse the repository at this point in the history