Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old services not getting removed from consul on update #1668

Merged
merged 7 commits into from
Sep 1, 2016
Merged

Fix old services not getting removed from consul on update #1668

merged 7 commits into from
Sep 1, 2016

Commits on Aug 26, 2016

  1. Remove unused embedded lock on ExecContext

    @schmichael
    schmichael committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    53d7dfb View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2016

  1. Fix old services not getting removed from consul on update 

    Fixes #1661
    @schmichael
    schmichael committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    a63b2cc View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2016

  1. Remove extra consul service tracking entirely 

    Instead just remove all associated services on shutdown.
    @schmichael
    schmichael committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    1d8d6b5 View commit details
    Browse the repository at this point in the history

  2. Assert syncer state is consistent with consul's state

    @schmichael
    schmichael committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    bcbe49e View commit details
    Browse the repository at this point in the history

  3. Fix error message when querying consul fails

    @schmichael
    schmichael committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    75e18f2 View commit details
    Browse the repository at this point in the history

  4. Make comment more precise

    @schmichael
    schmichael committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    8c9f5b7 View commit details
    Browse the repository at this point in the history

  5. Query consul without helpers in test to be safe

    @schmichael
    schmichael committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    ff21ded View commit details
    Browse the repository at this point in the history