-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry all servers on RPC call failure #1735
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
64ac9b9
Retry all servers on RPC call failure
schmichael 6d9670e
Replace periodic handlers with event driven disco
schmichael 6b9be92
Fix agent server set test
schmichael 01ff307
consul -> Consul
schmichael 3bac143
noServers -> noServersErr
schmichael a35fb33
doDisco -> triggerDiscoveryCh; discovered -> serversDiscoveredCh
schmichael a4a61e8
Return csv of servers from Stats, not just count
schmichael 93fbc12
Flip disco chan; clarify method names/comments
schmichael d6b1496
Drop clumsy timeout on discovery notifications
schmichael ac90d1d
No need to put reaper ticker on the struct
schmichael ec81fc9
Fix lies found in comments by fact checkers
schmichael ac29e9c
Remove unused const
schmichael 64aa187
Add #1735 related fixes/improvements to changelog
schmichael 91936f4
Cleanup changelog entries
schmichael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ IMPROVEMENTS: | |
* core: Introduce node SecretID which can be used to minimize the available | ||
surface area of RPCs to malicious Nomad Clients [GH-1597] | ||
* cli: `nomad alloc-status` shows allocation creation time [GH-1623] | ||
* client: Retry all servers on RPC call failure [GH-1735] | ||
* client: Enforce shared allocation directory disk usage [GH-1580] | ||
* client: Introduce a `secrets/` directory to tasks where sensitive data can | ||
be written [GH-1681] | ||
|
@@ -17,6 +18,8 @@ BUG FIXES: | |
* client/fingerprint: Fix inconsistent CPU MHz fingerprinting [GH-1366] | ||
* discovery: Fix old services not getting removed from consul on update | ||
[GH-1668] | ||
* discovery: Fix client flapping when server was in a different datacenter | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. was -> is +/- different datacenter as the client |
||
[GH-1641] | ||
* discovery: Fix HTTP timeout with Server HTTP health check when there is no | ||
leader [GH-1656] | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed RPCs are retried on all servers