-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 'default' alias not added to interface specified by network_interface
#18096
Merged
tgross
merged 4 commits into
hashicorp:main
from
kevinschoonover:kschoon/multi-alias-default
Aug 1, 2023
Merged
fix 'default' alias not added to interface specified by network_interface
#18096
tgross
merged 4 commits into
hashicorp:main
from
kevinschoonover:kschoon/multi-alias-default
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work on this @kevinschoonover!
Two things:
- Can you run
make cl
here to add a changelog entry? - Can you rebase on
main
? We accidentally landed a change inmain
that's breaking tests, which I've fixed in scheduler: fix panic inrender_templates
destructive update check #18100 but you don't have on your branch.
c250d0d
to
4202288
Compare
tgross
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This will ship in the next Nomad 1.6.x release and get backported to 1.5.x and 1.4.x
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.4.x
backport to 1.4.x release line
backport/1.5.x
backport to 1.5.x release line
backport/1.6.x
backport to 1.6.x release line
stage/waiting-reply
theme/fingerprint
theme/networking
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18097
consider the following config.hcl
whenever you would schedule the following job
you would see
* Constraint "missing host network \"default\" for port \"http\"": 1 nodes excluded by filter
because the 'default' host_network alias is being replaces with 'tailscale'. The follow PR appends the 'default' alias regardless to the addresses specified bynetwork_interface
.