Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix 'default' alias not added to interface specified by network_interface into release/1.6.x #18116

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18096 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


closes #18097

consider the following config.hcl

# config.hcl
client {
  network_interface = "tailscale0"

  host_network "tailscale" {
    interface = "tailscale0"
  }

  host_network "public" {
    interface = "wlan0"
  }
}

whenever you would schedule the following job

# job.hcl
job "docs" {
  datacenters = ["dc1"]

  group "example" {
    network {
      port "http" {}
    }
    task "server" {
      driver = "docker"

      config {
        image = "hashicorp/http-echo"
        ports = ["http"]
        args = [
          "-listen",
          ":5678",
          "-text",
          "hello world",
        ]
      }
    }
  }
}

you would see * Constraint "missing host network \"default\" for port \"http\"": 1 nodes excluded by filter because the 'default' host_network alias is being replaces with 'tailscale'. The follow PR appends the 'default' alias regardless to the addresses specified by network_interface.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/kschoon/multi-alias-default/forcibly-causal-crayfish branch from 9dd0dd3 to 790c6b1 Compare August 1, 2023 12:36
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/kschoon/multi-alias-default/forcibly-causal-crayfish branch from 790c6b1 to 9dd0dd3 Compare August 1, 2023 12:36
@tgross tgross force-pushed the backport/kschoon/multi-alias-default/forcibly-causal-crayfish branch from 9dd0dd3 to ece9dce Compare August 1, 2023 12:37
@tgross tgross merged commit e6d0326 into release/1.6.x Aug 1, 2023
6 of 8 checks passed
@tgross tgross deleted the backport/kschoon/multi-alias-default/forcibly-causal-crayfish branch August 1, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants