Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of e2e: fix and modernize rescheduling test into release/1.6.x #19107

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #19105 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@tgross
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/nomad/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


The E2E test suite for rescheduling had a few bugs:

This changeset also updates the whole test suite to move it off the v1 "framework". The test assertions are otherwise left untouched.

Fixes: #19076


Example run:

$ go test -v ./e2e/rescheduling -count=1 -timeout=20m
=== RUN   TestRescheduling_Service_NoReschedule
--- PASS: TestRescheduling_Service_NoReschedule (1.33s)
=== RUN   TestRescheduling_System_NoReschedule
--- PASS: TestRescheduling_System_NoReschedule (1.10s)
=== RUN   TestRescheduling_Default
--- PASS: TestRescheduling_Default (36.17s)
=== RUN   TestRescheduling_MaxAttempts
--- PASS: TestRescheduling_MaxAttempts (2.28s)
=== RUN   TestRescheduling_Success
--- PASS: TestRescheduling_Success (1.10s)
=== RUN   TestRescheduling_WithUpdate
--- PASS: TestRescheduling_WithUpdate (4.26s)
=== RUN   TestRescheduling_WithCanary
--- PASS: TestRescheduling_WithCanary (6.70s)
=== RUN   TestRescheduling_WithCanaryAutoRevert
--- PASS: TestRescheduling_WithCanaryAutoRevert (11.05s)
=== RUN   TestRescheduling_MaxParallel
--- PASS: TestRescheduling_MaxParallel (11.54s)
=== RUN   TestRescheduling_MaxParallelAutoRevert
--- PASS: TestRescheduling_MaxParallelAutoRevert (12.06s)
=== RUN   TestRescheduling_ProgressDeadline
--- PASS: TestRescheduling_ProgressDeadline (22.12s)
=== RUN   TestRescheduling_ProgressDeadlineFail
--- PASS: TestRescheduling_ProgressDeadlineFail (21.23s)
PASS
ok      github.com/hashicorp/nomad/e2e/rescheduling     130.965s

Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/e2e-rescheduling/factually-warm-jawfish branch 2 times, most recently from 43b348d to 8253df0 Compare November 16, 2023 20:39
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

The E2E test suite for rescheduling had a few bugs:
* Using the command line to stop a job with a failing deployment returns a non-zero exit
  code, which would cause an otherwise passing test to fail.
* Two of the input jobs were actually invalid but were only correctly detected
  as such because of #17342

This changeset also updates the whole test suite to move it off the v1
"framework". A few test assertions are also de-flaked.

Fixes: #19076
@tgross tgross force-pushed the backport/e2e-rescheduling/factually-warm-jawfish branch from 9cad3bf to a3b5de0 Compare November 16, 2023 20:44
@tgross tgross marked this pull request as ready for review November 16, 2023 20:46
@tgross tgross merged commit f2ade2e into release/1.6.x Nov 16, 2023
16 checks passed
@tgross tgross deleted the backport/e2e-rescheduling/factually-warm-jawfish branch November 16, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants