deps: update go-metrics to v0.5.3 #19190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
jrasell
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
LGTM!
$ ag "github.com/armon/go-metrics"
go.mod
165: github.com/armon/go-metrics v0.4.1 // indirect
CHANGELOG.md
1012:* deps: Updated `github.com/armon/go-metrics` to `v0.4.1` which includes a performance improvement for Prometheus sink [[GH-14493](https://github.com/hashicorp/nomad/issues/14493)]
go.sum
298:github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da/go.mod h1:Q73ZrmVTwzkszR9V5SSuryQ31EELlFMUz1kKyl939pY=
299:github.com/armon/go-metrics v0.0.0-20190430140413-ec5e00d3c878/go.mod h1:3AMJUQhVx52RsWOnlkpikZr01T/yAVN2gn0861vByNg=
300:github.com/armon/go-metrics v0.4.1 h1:hR91U9KYmb6bLBYLQjyM+3j+rcd/UhE+G78SFnF8gJA=
301:github.com/armon/go-metrics v0.4.1/go.mod h1:E6amYzXo6aW1tqzoZGT755KkbgrJsSdpwZ+3JqfkOG4=
Did we want to backport this, so that future dep updates can also be backported that include bug fixes?
tgross
approved these changes
Nov 28, 2023
lgfa29
added
backport/1.4.x
lgfa29
added a commit
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
lgfa29
added a commit
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
lgfa29
added a commit
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
lgfa29
added a commit
that referenced
this pull request
Nov 28, 2023
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
lgfa29
added a commit
that referenced
this pull request
Dec 7, 2023
lgfa29
added a commit
that referenced
this pull request
Dec 7, 2023
tgross
pushed a commit
that referenced
this pull request
Dec 8, 2023
tgross
pushed a commit
that referenced
this pull request
Dec 8, 2023
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
…rp#19374) * Revert "deps: update go-metrics to v0.5.3 (hashicorp#19190)" This reverts commit ddb060d. * changelog: add entry for hashicorp#19374
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
Update `go-metrics` to v0.5.3 to pick hashicorp/go-metrics#146.
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
…rp#19374) * Revert "deps: update go-metrics to v0.5.3 (hashicorp#19190)" This reverts commit ddb060d. * changelog: add entry for hashicorp#19374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
go-metricsto v0.5.3 to pick hashicorp/go-metrics#146.go-metricsv0.5.0 switch fromarmon/go-metricstohashicorp/go-metrics, so update those references as well.The indirect reference in
go.modcomes fromhashicorp/memberlist.