Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of deps: update go-metrics to v0.5.3 into release/1.4.x #19206

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #19190 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@lgfa29
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/nomad/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Update go-metrics to v0.5.3 to pick hashicorp/go-metrics#146.

go-metrics v0.5.0 switch from armon/go-metrics to hashicorp/go-metrics, so update those references as well.

The indirect reference in go.mod comes from hashicorp/memberlist.

$ go mod why -m github.com/armon/go-metrics
# github.com/armon/go-metrics
github.com/hashicorp/nomad/command/agent
github.com/hashicorp/memberlist
github.com/armon/go-metrics

Overview of commits

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui November 28, 2023 17:47 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad November 28, 2023 17:47 Inactive
@lgfa29
Copy link
Contributor

lgfa29 commented Nov 28, 2023

Manually backported

@lgfa29 lgfa29 closed this Nov 28, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants