Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TLS support in api pkg / cli #3108

Merged
merged 3 commits into from
Aug 28, 2017
Merged

Fix TLS support in api pkg / cli #3108

merged 3 commits into from
Aug 28, 2017

Commits on Aug 28, 2017

  1. Fix TLS support in api pkg / cli 

    Fixes #3013

It's a little weird that Client now has a method for returning a
NewClient, but it's a convenient way to dedupe the logic to
connect-directly-to-a-node which is nontrivial and had sutble
differences between locations.
    @schmichael
    schmichael committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    1bb8a54 View commit details
    Browse the repository at this point in the history

  2. Refactor GetNodeClient weirdness 

    - No need to for a pointer to a pointer
- Properly set and use QueryOptions.Region
    @schmichael
    schmichael committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    2f30827 View commit details
    Browse the repository at this point in the history

  3. Simplify region handling

    @schmichael
    schmichael committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    52857a6 View commit details
    Browse the repository at this point in the history