Implement preemption for system jobs. #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preetapan
force-pushed
the
f-preemption-systemjobs
branch
from
44c85b5
to
1b06413
Compare
This commit implements an allocation selection algorithm for finding allocations to preempt. It currently special cases network resource asks from others (cpu/memory/disk/iops).
preetapan
force-pushed
the
f-preemption-core
branch
from
282a027
to
c395008
Compare
Scheduler config API
|
Closing this and the other PR #4732, both are against a feature branch. I will be rebasing against master since the resources structs have changed quite a bit. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress PR for preemption.
Currently, the approach implemented special cases network resource asks, by preempting per task rather than per task group. This will allow us to preempt allocations on different network devices for the same task group (e.g scenario - task
t1will preempt allocs usingeth0, and taskt2will preempt allocs usingeth1).Wrote several unit test cases in preemption_test.go, but will be adding more next week.