Update shirou/gopsutil dep to use non-GPL code #5202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used `github.com/shirou/gopsutil`[1], used some GPL code [2]. This was somewhat unintentional, and was addressed later [3]. Due to being late in the cycle of Nomad release when this is noticed, and time elapsed since we updated the dependency, we want to be conservative in our package updates. As such, we opted to go with forking the repo to use the previously used version with the GPL removal code commit, done in [4]. [1] shirou/gopsutil@5776ff9 [2] https://github.com/shirou/gopsutil/blob/5776ff9c7c5d063d574ef53d740f75c68b448e53/host/include/smc.c [3] shirou/gopsutil@c95755e [4] https://github.com/shirou/gopsutil/commits/62d5761ddb7d04fc475d6316c79ff0eed1e5f96b
schmichael
approved these changes
Jan 17, 2019
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously used
github.com/shirou/gopsutil[1], used some GPL code [2].This was somewhat unintentional, and was addressed later [3][4].
Due to being late in the cycle of Nomad release when this is noticed,
and time elapsed since we updated the dependency, we want to be
conservative in our package updates.
As such, we opted to go with forking the repo to use the previously used
version with the GPL removal code commit, done in [5].
[1] shirou/gopsutil@5776ff9
[2] https://github.com/shirou/gopsutil/blob/5776ff9c7c5d063d574ef53d740f75c68b448e53/host/include/smc.c
[3] shirou/gopsutil@c95755e
[4] shirou/gopsutil#518
[5] https://github.com/shirou/gopsutil/commits/62d5761ddb7d04fc475d6316c79ff0eed1e5f96b