Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopsutil contains some GPL-licensed code #518

Closed
vadorovsky opened this issue Apr 26, 2018 · 4 comments
Closed

gopsutil contains some GPL-licensed code #518

vadorovsky opened this issue Apr 26, 2018 · 4 comments

Comments

@vadorovsky
Copy link
Contributor

gopsutil is licensed under BSD 3-clause license https://github.com/shirou/gopsutil/blob/master/LICENSE

However, its code contains two files which are licensed under GPL and are most probably just copied from some project:

https://github.com/shirou/gopsutil/blob/master/host/include/smc.c#L1-L35
https://github.com/shirou/gopsutil/blob/master/host/include/smc.h#L1-L35

Can somebody explain how that code was introduced there? I think that we should get rid of it and (if possible) use something released under BSD/MIT/Apache or anything other license with is compatible with BSD.

I discovered that issue when I tried to package https://github.com/google/gops in openSUSE and our infra detected that there is some GPL-licensed code, despite the fact, that the whole project is licensed under more "liberal" licenses.

/cc @shirou

@vadorovsky
Copy link
Contributor Author

The only source file which actually uses the GPL-licensed content:

https://github.com/shirou/gopsutil/blob/master/host/host_darwin_cgo.go

@shirou
Copy link
Owner

shirou commented Apr 27, 2018

I am really apologize about include GPL files. These files are introduced by #344 and I have not notice those are under GPL.

I removed those on c95755e and released v2.18.04. (usually release is end of month, but this problem is emergency)

@vadorovsky
Copy link
Contributor Author

Thanks a lot!

vadorovsky added a commit to vadorovsky/gops that referenced this issue Apr 27, 2018
gopsutil library is licensed under BSD, but the previous version
contained some GPL-licensed code which is a violation of GPL
license. The updated version doesn't contain GPL-licensed code
anymore.

shirou/gopsutil#518
vadorovsky added a commit to vadorovsky/gops that referenced this issue Apr 27, 2018
gopsutil library is licensed under BSD, but the previous version
contained some GPL-licensed code which is a violation of GPL
license. The updated version doesn't contain GPL-licensed code
anymore.

shirou/gopsutil#518
rakyll pushed a commit to google/gops that referenced this issue Apr 30, 2018
gopsutil library is licensed under BSD, but the previous version
contained some GPL-licensed code which is a violation of GPL
license. The updated version doesn't contain GPL-licensed code
anymore.

shirou/gopsutil#518
@danielnelson
Copy link
Contributor

Looks like these files were actually added in #334, not the issue referenced above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants