Avoid de-registering slowly restored services - attempt 2 #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a nomad client restarts/upgraded, nomad restores state from running task and starts the sync loop. If sync loop runs early, it may deregister services from Consul prematurely even when Consul has the running service as healthy. This is not ideal, as re-registering the service means potentially waiting a whole service health check interval before declaring the service healthy. We attempt to mitigate against this by introducing a delay for deleting consul services and checks that we didn't explicitly de-registered. So if we notice a service not recognized by Nomad yet, delete it after a delay period (e.g. 5 minutes here), unless it's registered by then.
|
closing as the alternative #5837 was merged already. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation to #5837 that I didn't like as much.
Here, we attempt to mitigate against this by introducing a delay for deleting
consul services and checks that we didn't explicitly de-registered. So
if we notice a service not recognized by Nomad yet, delete it after a
delay period (e.g. 5 minutes here), unless it's registered by then.
I believe #5837 is a bit simpler but opening this as draft if folks want to discuss it