Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid de-registering slowly restored services - attempt 2 #5838

Closed
wants to merge 1 commit into from
Closed

Avoid de-registering slowly restored services - attempt 2 #5838

wants to merge 1 commit into from

Commits on Jun 14, 2019

  1. Avoid de-registering slowly restored services 

    When a nomad client restarts/upgraded, nomad restores state from running
task and starts the sync loop.  If sync loop runs early, it may
deregister services from Consul prematurely even when Consul has the
running service as healthy.

This is not ideal, as re-registering the service means potentially
waiting a whole service health check interval before declaring the
service healthy.

We attempt to mitigate against this by introducing a delay for deleting
consul services and checks that we didn't explicitly de-registered.  So
if we notice a service not recognized by Nomad yet, delete it after a
delay period (e.g. 5 minutes here), unless it's registered by then.
    Mahmood Ali committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    0076117 View commit details
    Browse the repository at this point in the history