Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add page titles #5924

Merged
merged 17 commits into from
Jul 17, 2019
Merged

UI: Add page titles #5924

merged 17 commits into from
Jul 17, 2019

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Jul 4, 2019

This adds dynamic titles, as shown in this GIF:

titles

I’ll stop here and make a list of proposed page titles.
“Job [Job name] - Nomad” seems preferable to
“[Job name] - Jobs - Nomad”
This facilitates the possibility of page titles live-updating
based on model characteristics.
ember-page-title directly supports passing a list of strings
for concatenation.
This only happened because I had changed a title token in this file.
@backspace backspace requested a review from a team July 17, 2019 16:44
@johncowen
Copy link
Contributor

Hey @backspace

I took a very quick look at this, I'm circle back tomorrow if nobody else has been here. I think my only thing from a user perspective would be..

What's your thoughts on putting the 'most important' thing at the front of the title, so the name of the job or whatever. Tabs are generally pretty small and when they get smaller, if I was to have multiple tabs open I would be able to distinguish between them easier if the name of the job was at the start instead of the word 'Job'

Overall, this seems fine to me other than that, lemme know what you think on ^. Otherwise I'll circle back in the morning and give it a final look over.

Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed a little inconsistency between single and double quotes other than that LGTM!

Visual Studio Code autocomplete!!!
@backspace backspace merged commit 87d716e into master Jul 17, 2019
@backspace backspace deleted the f-ui/titles branch July 17, 2019 20:03
@DingoEatingFuzz
Copy link
Contributor

I'm obviously late to the party, but I wanted to look at this too, and it looks nice! And of course there's an ember addon for title management ✨

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants