-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add page titles #5924
Merged
Merged
UI: Add page titles #5924
Commits on Jul 4, 2019
-
I’ll stop here and make a list of proposed page titles.
Configuration menu - View commit details
-
Copy full SHA for cc69b05 - Browse repository at this point
Copy the full SHA cc69b05View commit details
Commits on Jul 5, 2019
-
“Job [Job name] - Nomad” seems preferable to “[Job name] - Jobs - Nomad”
Configuration menu - View commit details
-
Copy full SHA for d91f332 - Browse repository at this point
Copy the full SHA d91f332View commit details -
This facilitates the possibility of page titles live-updating based on model characteristics.
Configuration menu - View commit details
-
Copy full SHA for b6cb9b1 - Browse repository at this point
Copy the full SHA b6cb9b1View commit details
Commits on Jul 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5861f1a - Browse repository at this point
Copy the full SHA 5861f1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36add15 - Browse repository at this point
Copy the full SHA 36add15View commit details -
Remove unnecessary concat helpers
ember-page-title directly supports passing a list of strings for concatenation.
Configuration menu - View commit details
-
Copy full SHA for c2d52c1 - Browse repository at this point
Copy the full SHA c2d52c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1361d6c - Browse repository at this point
Copy the full SHA 1361d6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5763b92 - Browse repository at this point
Copy the full SHA 5763b92View commit details -
This only happened because I had changed a title token in this file.
Configuration menu - View commit details
-
Copy full SHA for 11a59b9 - Browse repository at this point
Copy the full SHA 11a59b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd907a5 - Browse repository at this point
Copy the full SHA fd907a5View commit details
Commits on Jul 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 72cd2e7 - Browse repository at this point
Copy the full SHA 72cd2e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71b56d8 - Browse repository at this point
Copy the full SHA 71b56d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7af7feb - Browse repository at this point
Copy the full SHA 7af7febView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27784ee - Browse repository at this point
Copy the full SHA 27784eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b696fab - Browse repository at this point
Copy the full SHA b696fabView commit details
Commits on Jul 17, 2019
-
Change title strings to all use double quotes
Thanks to @johncowen for catching this! 😝
Configuration menu - View commit details
-
Copy full SHA for ad3f3ce - Browse repository at this point
Copy the full SHA ad3f3ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for e006a81 - Browse repository at this point
Copy the full SHA e006a81View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.