Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add page titles #5924

Merged
merged 17 commits into from
Jul 17, 2019
Merged

UI: Add page titles #5924

merged 17 commits into from
Jul 17, 2019

Commits on Jul 4, 2019

  1. Add example page titles 

    I’ll stop here and make a list of proposed page titles.
    @backspace
    backspace committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    cc69b05 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Move jobs token into index 

    “Job [Job name] - Nomad” seems preferable to
“[Job name] - Jobs - Nomad”
    @backspace
    backspace committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    d91f332 View commit details
    Browse the repository at this point in the history

  2. Migrate to ember-page-title 

    This facilitates the possibility of page titles live-updating
based on model characteristics.
    @backspace
    backspace committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    b6cb9b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2019

  1. Merge branch 'master' into f-ui/titles

    @backspace
    backspace committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    5861f1a View commit details
    Browse the repository at this point in the history

  2. Add titles to job routes

    @backspace
    backspace committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    36add15 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary concat helpers 

    ember-page-title directly supports passing a list of strings
for concatenation.
    @backspace
    backspace committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    c2d52c1 View commit details
    Browse the repository at this point in the history

  4. Add titles for other pages but allocations

    @backspace
    backspace committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    1361d6c View commit details
    Browse the repository at this point in the history

  5. Add titles for allocation routes

    @backspace
    backspace committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    5763b92 View commit details
    Browse the repository at this point in the history

  6. Revert unrelated autofix 

    This only happened because I had changed a title token in this file.
    @backspace
    backspace committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    11a59b9 View commit details
    Browse the repository at this point in the history

  7. Remove head comments

    @backspace
    backspace committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    fd907a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. Change task group title

    @backspace
    backspace committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    72cd2e7 View commit details
    Browse the repository at this point in the history

  2. Update correct test

    @backspace
    backspace committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    71b56d8 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @backspace
    backspace committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    7af7feb View commit details
    Browse the repository at this point in the history

  4. Add region to title when switcher is shown

    @backspace
    backspace committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    27784ee View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into f-ui/titles 

    # Conflicts:
#	CHANGELOG.md
    @backspace
    backspace committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    b696fab View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Change title strings to all use double quotes 

    Thanks to @johncowen for catching this! 😝
    @backspace
    backspace committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    ad3f3ce View commit details
    Browse the repository at this point in the history

  2. Fix doubled quotes 

    Visual Studio Code autocomplete!!!
    @backspace
    backspace committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    e006a81 View commit details
    Browse the repository at this point in the history