Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: canonicalize before adding sidecar #6855

Merged
merged 2 commits into from
Dec 13, 2019
Merged

connect: canonicalize before adding sidecar #6855

merged 2 commits into from
Dec 13, 2019

Commits on Dec 13, 2019

  1. connect: canonicalize before adding sidecar 

    Fixes #6853

Canonicalize jobs first before adding any sidecars. This fixes a bug
where sidecar tasks were added without interpolated names and broke
validation. Sidecar tasks must be canonicalized independently.

Also adds a group network to the mock connect job because it wasn't a
valid connect job before!
    @schmichael
    schmichael committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    c74de6a View commit details
    Browse the repository at this point in the history

  2. docs: add #6855 to changelog 

    Also make Connect related fixes more consistent in the changelog. I
suspect users won't care if a Connect related fix is in the server's
admission controller or in the client's groupservice hook or somewhere
else, so I think grouping them by `consul/connect:` makes the most
sense.
    @schmichael
    schmichael committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    4f718f7 View commit details
    Browse the repository at this point in the history