-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker 19.03.8 #7351
Docker 19.03.8 #7351
Conversation
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Looks like the latest `github.com/docker/docker/registry.ResolveAuthConfig` expect `github.com/docker/docker/api/types.AuthConfig` rather than `github.com/docker/cli/cli/config/types.AuthConfig`. The two types are identical but live in different packages. Here, we embed `registry.ResolveAuthConfig` from upstream repo, but with the signature we need.
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
it needs that one, moby/moby#40021 |
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
At some point, wouldn't it be easier to have docker as a separated plugin? |
Having Docker as external plugin would be huge :) |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
A follow up to #7350
docker
's is incompatible withgolang.org/x/sys/windows
which is required bygopsutils
.moby
should upgrade to a fresher version. (or I'm doing it wrong and it's much easier than that)