Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker v19.03.8 #7531

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Docker v19.03.8 #7531

merged 2 commits into from
Mar 30, 2020

Conversation

greut
Copy link
Contributor

@greut greut commented Mar 28, 2020 •
edited
Loading

Changelog:

Related issues / PRs:

@greut greut mentioned this pull request Mar 28, 2020
Closed
1 task
@greut greut marked this pull request as ready for review March 28, 2020 09:43
greut and others added 2 commits March 28, 2020 17:29
@greut
docker: v19.03.8
ace5ab1 
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@greut
Resolve docker types conflict
4667440 
Looks like the latest `github.com/docker/docker/registry.ResolveAuthConfig` expect
`github.com/docker/docker/api/types.AuthConfig` rather than
`github.com/docker/cli/cli/config/types.AuthConfig`. The two types are
identical but live in different packages.

Here, we embed `registry.ResolveAuthConfig` from upstream repo, but with
the signature we need.
notnoop
notnoop approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did basic testing - will merge and run more tests with it - and update fsouza/go-docker-client

@notnoop notnoop merged commit a7999c2 into hashicorp:master Mar 30, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@greut @notnoop