Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor gopsutil with go mod fix #8108

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Vendor gopsutil with go mod fix #8108

merged 1 commit into from
Jun 3, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Jun 3, 2020

Point to gopsutil fork with shirou/gopsutil#889 changes. I used hashicorp/gopsutil rather than pointing to https://github.com/Lomanic/gopsutil/tree/issue832 directly just in case..

@notnoop notnoop requested a review from shoenig June 3, 2020 19:14
@shoenig
Copy link
Member

shoenig commented Jun 3, 2020

LGTM, would like to rerun the tests to get past transient failures. gopsutil always has an extra surprise ready

Base automatically changed from vendor-sync-20200603 to master June 3, 2020 19:34
@notnoop
Copy link
Contributor Author

notnoop commented Jun 3, 2020

I rebased to account for #8107 being merged.

@notnoop notnoop merged commit fa845c7 into master Jun 3, 2020
@notnoop notnoop deleted the c-gopsutil-go-mod-fork branch June 3, 2020 20:09
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants