[darwin][disk][host] Move C dependencies to satisfy go mod and have descriptive file names #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules not including C files Supersedes shirou#885 by @afontaine
notnoop
pushed a commit
to hashicorp/nomad
that referenced
this pull request
Jun 3, 2020
Point to gopsutil fork with shirou/gopsutil#889 changes. I used hashicorp/gopsutil rather than pointing to https://github.com/Lomanic/gopsutil/tree/issue832 directly just in case..
|
Thanks @Lomanic for this PR. Just letting you know that we've adopted this PR in https://github.com/hashicorp/nomad and so far so good. Thanks for the fix! |
|
Thanks for letting me know @notnoop 👍 |
1 task
10 tasks
3 tasks
Mic92
added a commit
to Mic92/telegraf
that referenced
this pull request
Aug 15, 2020
This was fixed here shirou/gopsutil#889 We use go mod vendor in NixOS to archive all dependencies and allow reproducible offline builds. Changelog is minimal otherwise: - https://github.com/shirou/gopsutil/releases/tag/v2.20.6
shoenig
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 17, 2020
The PR we needed shirou/gopsutil#889 has been merged upstream, which means we can use upstream rather than our fork of psutil.
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this pull request
Oct 22, 2020
The PR we needed shirou/gopsutil#889 has been merged upstream, which means we can use upstream rather than our fork of psutil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.