UI: Change edition to Octane #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the data-test-* attributes used when invoking the component had nowhere to go.
Since template-only components are now Glimmer components, references that used to be available from this. now require the @ sigil.
There was a conflict between this being called attributes and the splattributes that are available for Glimmer components.
Ember Asset Size actionAs of 6fec3f2 Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
DingoEatingFuzz
approved these changes
Jul 10, 2020
20 tasks
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Ember edition setting to Octane, which I removed from #8319
because it required the template-only Glimmer components setting to be turned
on, which broke some tests and seemed preferable to separate out.
It didn’t require that many changes, probably because there aren’t that many
template-only components. One template needed an
...attributesto handlea test selector, a few templates needed
this.changed to@, and theAttributesTablecomponent needed itsattributesproperty renamed toavoid collision with splattributes. I chose the somewhat-clunky
attributePairsbut I’m open to suggestions!
At first I was concerned that this would be a confusing developer experience,
not knowing whether to use
this.or@based on whether or not it was aGlimmer component, but
@will almost always work, thankfully. One exceptionI came across while preparing this PR was
RescheduleEventRow, whichuses an overridable
allocationproperty to either accept an allocation beingpassed in or fetch one via
allocationId, but that’s all I saw.