Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix typo in exec button URL-generation #8460

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Conversation

backspace
Copy link
Contributor

This closes #8422, another bug facilitated by the difficulty
of automated testing when opening another window. Thanks to
@notnoop for narrowing this down.

This closes #8422, another bug facilitated by the difficulty
of automated testing when opening another window. Thanks to
@notnoop for narrowing this down.
@github-actions
Copy link

Ember Asset Size action

As of 81e7006

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +6 B +1 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

master 81e7006 change
passes 1289 1289 0
failures 0 0 0
flaky 0 0 0
duration 5m 40s 994ms 6m 05s 833ms +24s 839ms

@backspace backspace merged commit a4a5343 into master Jul 20, 2020
@backspace backspace deleted the b-ui/exec-allocation branch July 20, 2020 21:06
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exec in to container (from UI) always goes to the last allocation
2 participants