UI: Add specificity to exec allocation URL generation #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @notnoop for this UX improvement suggestion. The allocation’s task group is always known, so it might as well be preselected in the sidebar when the exec window opens. Also, if the task group only has one task, might as well preselect it too. This is perhaps at or beyond the limit of where it makes sense to use non-Ember Data pseudo-models in the tests 😶
backspace
changed the title
Ember Asset Size actionAs of b06403f Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
DingoEatingFuzz
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
I don't mind the mocks in the tests. Maybe a little utility would make the tests less verbose, but generally speaking I think verbosity in tests is good. Makes it extra clear what's happening and reduces the amount of indirect consequences that could cause a test to fail.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @notnoop for this UX improvement suggestion.
The allocation’s task group is always known, so it
might as well be preselected in the sidebar when the
exec window opens. Also, if the task group only has
one task, might as well preselect it too.
Review notes:
• this is perhaps at or beyond the limit of where it makes sense to use non-Ember Data pseudo-models in the tests 😶
• testing this locally doesn’t work without the fix in #8460 but I didn’t make that the base because they’re technically orthogonal