UI: Change compared page object to match by name #8915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this test became flaky after #8833, you can see an example failure here: https://app.circleci.com/pipelines/github/hashicorp/nomad/11809/workflows/0dc3c8f4-187c-44af-8bdb-6f010d653081/jobs/100848 My understanding of the goal here is not to assert that the first task group in the server database matches the first row displayed, but that before #8833 it could be assumed that they did match. This changes to find the row corresponding to the first server task group instead of assuming it’ll be first.
Ember Asset Size actionAs of 29652bd Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
DingoEatingFuzz
approved these changes
Sep 17, 2020
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this pull request
Sep 28, 2020
I believe this test became flaky after hashicorp#8833, you can see an example failure here: https://app.circleci.com/pipelines/github/hashicorp/nomad/11809/workflows/0dc3c8f4-187c-44af-8bdb-6f010d653081/jobs/100848 The goal here is not to assert that the first task group in the server database matches the first row displayed, but before hashicorp#8833 it could be assumed that they did match. This changes to find the row corresponding to the first server task group instead of assuming it’ll be first.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this test became flaky after #8833, you can see
an example failure here:
https://app.circleci.com/pipelines/github/hashicorp/nomad/11809/workflows/0dc3c8f4-187c-44af-8bdb-6f010d653081/jobs/100848
My understanding is the aim here is not to assert that the
first task group in the server database matches the first
row displayed, but that before #8833 it could be assumed
that they did match. This changes to find the row corresponding
to the first server task group instead of assuming it’ll
be first.