-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-getter to v1.5.1 with support for vhost style S3 paths #9349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scratch that, i'm seeing a different complaint, looking into it now. |
Yup, this fix should also resolve #8454 👍 |
Is this mergable? I don't quite understand what the lint failure is:
|
d1f820e
to
3bc6690
Compare
That's because we needed to run I've rebased this PR on master and updated the go.sum to match. |
Well now the linter is getting the same error I got locally when I tried to make sync, except with the old checksum:
|
So as far as I can tell the Edit: looks like it's a go module proxy problem. Using |
Ok, following an internal discussion it looks like this was down to a release error in go-getter for the 1.5.1 tag. I've bumped go-getter to 1.5.2 and this should be safe to merge after that. |
Thank you everyone that helped get this debugged / merged! 🙇 |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Aims to fix #9050 and related to hashicorp/go-getter#263