Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go getter #9555

Closed
wants to merge 3 commits into from
Closed

Update go getter #9555

wants to merge 3 commits into from

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Dec 7, 2020

replay of #9349

resolves #9050 and #8454

@cgbaker cgbaker requested a review from picatz December 7, 2020 22:18
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui December 7, 2020 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 7, 2020 22:20 Inactive
@cgbaker
Copy link
Contributor Author

cgbaker commented Dec 7, 2020

i locally ran go clean -modcache and go mod tidy and I'm seeing a consistent go.sum. it's possible that the module cache on the circleci instance is poisoned with a bad checksum.

@picatz
Copy link
Contributor

picatz commented Dec 7, 2020

Hmmm. For context, I had minor trouble with that v1.5.1 release. IIRC the tag I pushed was reverted since the CI workflow failed and @mdeggies fixed it.

🤔 Maybe that is related or the cause of the go.mod error?

@tgross
Copy link
Member

tgross commented Jan 7, 2021

I didn't realize we had a second PR open for it, but I think I have the build issues resolved now in #9349 by bumping up to the 1.5.2 tag.

@tgross
Copy link
Member

tgross commented Jan 7, 2021

Closed by #9349

@tgross tgross closed this Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact stanza doesn't support AWS S3 virtual host style paths
3 participants