Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul/connect: interpolate connect block #9586

Merged
merged 3 commits into from
Dec 9, 2020
Merged

consul/connect: interpolate connect block #9586

merged 3 commits into from
Dec 9, 2020

Commits on Dec 9, 2020

  1. consul/connect: interpolate connect block 

    This PR enables job submitters to use interpolation in the connect
block of jobs making use of consul connect. Before, only the name of
the connect service would be interpolated, and only for a few select
identifiers related to the job itself (#6853). Now, all connect fields
can be interpolated using the full spectrum of runtime parameters.

Note that the service name is interpolated at job-submission time,
and cannot make use of values known only at runtime.

Fixes #7221
    @shoenig
    shoenig committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    4d0e745 View commit details
    Browse the repository at this point in the history

  2. docs: fixup changelog 

    Co-authored-by: Tim Gross <tgross@hashicorp.com>
    @shoenig @tgross
    shoenig and tgross committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    54653d2 View commit details
    Browse the repository at this point in the history

  3. consul/connect: avoid extra copy of connect stanza while interpolating

    @shoenig
    shoenig committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    edf1e25 View commit details
    Browse the repository at this point in the history