-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add button to fail running deployments #9831
Commits on Jan 15, 2021
-
Add button to fail running deployments
As suggested in #9826. The placement is currently ridiculous.
Configuration menu - View commit details
-
Copy full SHA for 61cca85 - Browse repository at this point
Copy the full SHA 61cca85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58dc406 - Browse repository at this point
Copy the full SHA 58dc406View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70cb7d3 - Browse repository at this point
Copy the full SHA 70cb7d3View commit details
Commits on Jan 18, 2021
-
Move fail button to latest deployment component
@DingoEatingFuzz clarified to me that the deployments page is meant to be a historical overview vs a place to change things.
Configuration menu - View commit details
-
Copy full SHA for bc853a2 - Browse repository at this point
Copy the full SHA bc853a2View commit details -
Change failure to require confirmation
As sensibly suggested by @picatz
Configuration menu - View commit details
-
Copy full SHA for 0ace71f - Browse repository at this point
Copy the full SHA 0ace71fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1d78b4 - Browse repository at this point
Copy the full SHA d1d78b4View commit details -
Add class overrides for two-step button
Since isInfoAction was only being used in the one place and I needed a different set of overrides for this context, it seemed to me sensible to decompose the overrides so they can be individually set in the invocation vs being bundled together under a not-totally-clear name.
Configuration menu - View commit details
-
Copy full SHA for 2be2338 - Browse repository at this point
Copy the full SHA 2be2338View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5faf2bc - Browse repository at this point
Copy the full SHA 5faf2bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4545ca - Browse repository at this point
Copy the full SHA b4545caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6159763 - Browse repository at this point
Copy the full SHA 6159763View commit details
Commits on Feb 10, 2021
-
Change CSS for two-step inline text
This is a less magic number-y approach than before, but since the buttons were previously spaced with an actual space character rather than CSS, some margins are needed to replicate that in the flexbox layout.
Configuration menu - View commit details
-
Copy full SHA for 13ab142 - Browse repository at this point
Copy the full SHA 13ab142View commit details