Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add button to fail running deployments #9831

Merged
merged 11 commits into from
Feb 10, 2021
Merged

Commits on Jan 15, 2021

  1. Add button to fail running deployments

    As suggested in #9826. The placement is currently ridiculous.
    backspace committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    61cca85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58dc406 View commit details
    Browse the repository at this point in the history
  3. Add missing semicolon

    backspace committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    70cb7d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Move fail button to latest deployment component

    @DingoEatingFuzz clarified to me that the deployments page
    is meant to be a historical overview vs a place to change
    things.
    backspace committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    bc853a2 View commit details
    Browse the repository at this point in the history
  2. Change failure to require confirmation

    As sensibly suggested by @picatz
    backspace committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    0ace71f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d1d78b4 View commit details
    Browse the repository at this point in the history
  4. Add class overrides for two-step button

    Since isInfoAction was only being used in the one place and
    I needed a different set of overrides for this context, it
    seemed to me sensible to decompose the overrides so they
    can be individually set in the invocation vs being bundled
    together under a not-totally-clear name.
    backspace committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    2be2338 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5faf2bc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b4545ca View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6159763 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Change CSS for two-step inline text

    This is a less magic number-y approach than before, but since
    the buttons were previously spaced with an actual space
    character rather than CSS, some margins are needed to replicate
    that in the flexbox layout.
    backspace committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    13ab142 View commit details
    Browse the repository at this point in the history