Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: region and region_code argument #59

Merged
merged 2 commits into from
Apr 7, 2023
Merged

fix: region and region_code argument #59

merged 2 commits into from
Apr 7, 2023

Conversation

youngmn
Copy link
Contributor

@youngmn youngmn commented Mar 16, 2023

Hello,
I'm a packer plugin developer for NCloud.

PR Summary

  • docs : region and region_code argument changed
  • Add a default value to region_code
  • Modify validation logic for region and region_code

@youngmn youngmn requested a review from a team as a code owner March 16, 2023 12:09
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@youngmn youngmn changed the title fix: region adn region_code argument fix: region and region_code argument Mar 16, 2023
wonchulee
wonchulee reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@wonchulee wonchulee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs-partials/builder/ncloud/Config-*-required.mdx file is different from the one generated by the make generate command, so it may be overwritten in future updates. When you run make generate, it is automatically generated with the comments written above each field of Config struct in config.go, but it would be nice if you could update the comments and run make generate, and upload it.
Other than that, it looks perfect. 👍

wonchulee
wonchulee approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@wonchulee wonchulee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 @nywilken could you review this change?

nywilken
nywilken approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not being able to get to this request sooner. The change looks good to me, as well. I'll merge once all goes green. Then I'll merge in the latest SDK and cut a release. @wonchulee thank you for the review.

@nywilken nywilken merged commit 896645f into hashicorp:main Apr 7, 2023
@wonchulee wonchulee mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonchulee wonchulee wonchulee approved these changes

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youngmn @hashicorp-cla @nywilken @wonchulee