Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve unknown configuration key error #64

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

wonchulee
Copy link
Contributor

@wonchulee wonchulee commented Jun 16, 2023

There was an issue with the packer failing to build images because an error was emitted due to the access_control_group_configuration_no config having gone. (#59 PR. )

Error: 1 error occurred:
	* unknown configuration key: '"access_control_group_configuration_no"'

It fixes by removing deprecated access_control_group_configuration_no config

@wonchulee wonchulee requested a review from a team as a code owner June 16, 2023 09:09
@wonchulee wonchulee marked this pull request as draft June 16, 2023 09:12
@wonchulee wonchulee changed the title fix: Resolve unknown configuration key(access_control_group_configuration_no) fix: Resolve unknown configuration key error Jun 16, 2023
@wonchulee
Copy link
Contributor Author

This change fixes to make the packer build work properly. If possible, I would be very grateful if you could release it right after the review. @nywilken

@wonchulee wonchulee marked this pull request as ready for review June 16, 2023 09:31
@nywilken nywilken added breaking-change regression version/bump minor A PR that changes behavior or contains breaking changes template configuration options. labels Jun 20, 2023
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wonchulee good catch. I'll merge and release as a new 1.1.0 release since the last release is broken and this removes a configuration option. Apologies for not catching that in the review.

For the next PR could you work on adding acceptance tests that can be ran locally please.

@nywilken nywilken added the bug label Jun 20, 2023
@nywilken nywilken merged commit 2b4c363 into hashicorp:main Jun 20, 2023
@wonchulee wonchulee deleted the fix_error branch June 21, 2023 01:02
@wonchulee
Copy link
Contributor Author

wonchulee commented Jun 21, 2023

Thanks @nywilken.
This worked when we tested it, but I think it might have gotten tangled up with the SDK changes. As you said, next time we are going to add an acceptance test to prevent this kind of issue.

@nywilken
Copy link
Contributor

Thanks @nywilken. This worked when we tested it, but I think it might have gotten tangled up with the SDK changes. As you said, next time we are going to add an acceptance test to prevent this kind of issue.

Thanks for confirming @wonchulee! Apologies for the delayed review/merge/release. Please send me an email at packer at hashicorp dot com as I would like to invite you into our committers packer Slack channel.

That said, the 0.4.0 release did contain changes that has introduced a few bugs within plugins so I would not be surprised if it cause an issue here. I'm working on getting a closer release/test cycle for the SDK to mitigate such issues in the future. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bug regression version/bump minor A PR that changes behavior or contains breaking changes template configuration options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants