Add support for traversals/references #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-traversal-expr
branch
from
04eb478 to
a7791e4
Compare
radeksimko
force-pushed
the
f-traversal-expr
branch
5 times, most recently
from
8a7bb79 to
9372020
Compare
radeksimko
commented
May 12, 2021
| } | ||
|
|
||
| // TODO: Omit item which uses kind unsupported by the client | ||
|
|
||
| var cmd *lsp.Command | ||
| if candidate.TriggerSuggest { | ||
| if candidate.TriggerSuggest && snippetSupport { |
There was a problem hiding this comment.
This is probably something that should've been done some time ago. We do not include the = in the simplified TextEdits and so triggering suggest in that case is kind of pointless.
It is not a big deal for most clients today which probably do support snippets anyway, but it also helps reducing the amount of test data where in test we opt into snippet support only where we need it.
radeksimko
force-pushed
the
f-traversal-expr
branch
2 times, most recently
from
4e9a443 to
b992415
Compare
radeksimko
force-pushed
the
f-traversal-expr
branch
from
b992415 to
0b882cb
Compare
radeksimko
force-pushed
the
f-traversal-expr
branch
from
0b882cb to
52157a9
Compare
This was referenced May 18, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on hashicorp/hcl-lang#36
Builds on hashicorp/terraform-schema#41
Some known (most likely desirable) features were intentionally left out from the MVP, but are tracked individually and will be eventually implemented:
typedeclarations: Support for type declarations (for variabletype) #490var.xorlocal.x): Support for references to variables and locals #491moduleoutputs & completion of inputs: Completion of module variables in module block #93Generally if something related to reference completion/hover etc. seems missing from that list, or the implementation I would suggest opening a new issue (rather than commenting here on this PR).
Screenshots