Add protobuf support for resource identity messages and rpcs #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
force-pushed
the
am/resource-identity
branch
2 times, most recently
from
012f578 to
f1f8392
Compare
2 tasks
austinvalle
previously approved these changes
Feb 5, 2025
| bytes type = 2; | ||
| bool required_for_import = 3; | ||
| bool optional_for_import = 4; | ||
| string description = 5; |
There was a problem hiding this comment.
FYI -> I asked core if we needed an additional StringKind description_kind = 6; here, but that shouldn't stop this PR/others from merging and moving forward!
ansgarm
force-pushed
the
am/resource-identity
branch
from
cc60b58 to
d2a6210
Compare
austinvalle
approved these changes
Feb 7, 2025
austinvalle
previously requested changes
Feb 7, 2025
|
Yeah, I'm on it.. But my local environment is silly and I can't seem to update my version of |
…r ApplyResourceChange.Request
ansgarm
force-pushed
the
am/resource-identity
branch
from
d2a6210 to
4c092e5
Compare
2 tasks
austinvalle
approved these changes
Feb 7, 2025
ansgarm
added a commit
that referenced
this pull request
Feb 10, 2025
austinvalle
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of https://hashicorp.atlassian.net/browse/TFECO-8804
This PR adds new PRC calls and messages for resource identity