tfprotov6: Resource Identity implementation #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
changed the title
3 tasks
austinvalle
previously approved these changes
Feb 12, 2025
There was a problem hiding this comment.
LGTM, the CI errors are all related to a new golangci-lint version (it gets shadow bumped by the github action 🙁 ), so you can just go ahead and merge 🚀
Opened a PR to fix the lint errors: #477
copied from protocol v5
Co-authored-by: Austin Valle <austinvalle@gmail.com>
austinvalle
force-pushed
the
am/resource-identity-protocolv6
branch
from
3026ee0 to
e611a70
Compare
|
Rebased, and now you have some actual lint errors in this PR to fix 🤣 , apologies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shamelessly copied from protocol v5 as merged via #474
differences to the other PR:
v6where the other usedv5v6was in a sub directoryThis PR also adds two changie entries for this change and the two related ones that already landed